Closed grayjk closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.12%. Comparing base (
167c34e
) to head (b718b68
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Not sure what's up with codecov. It says rate limiting and the token size is 0. Is CODECOV_TOKEN
still populated in secrets?
Yes I saw that... when I re-executed an individual test it was fine, but when I re-executed all it hit the rate limit again. CODECOV_TOKEN
is in secrets, its three years old.
Could be because this repo is a fork, https://github.com/codecov/feedback/issues/358 Not sure if this fix will make it to v3 or but supposedly they changed v4 to use the token even on forks. Only issue with v4 is it won't work with 2.7. We could add a workaround in the CI config to use v3 for 2.7 and v4 for everything else. I'm getting tired of all these CI workarounds, but 2.7 still had 27k downloads in the last month. That's about 1% of the total downloads.
This change is incorporated and credited in #275, thanks @grayjk
call Sequence.length/iter_parse fewer times
before:
after