search

jquast / telnetlib3

Python Telnet server and client Protocol library using asyncio
Other
144 stars 32 forks source link

Update test_writer.py to use pytest.raises(Error, match) #40

Closed aidanPB closed 4 years ago

aidanPB commented 4 years ago

Use the match keyword argument to pytest.raises() to make assertions about error messages. At some point pytest changed the string representation of ExceptionInfo objects, and the assertions against str(exc_info) were failing.

aidanPB commented 4 years ago

Not sure what's causing those connection resets under Python 3.5. It works under 3.6 and 3.7.

jquast commented 4 years ago

Hi!

thanks!!

I’ll take a look at 3.5 issue and merge soon.