search

jquast / telnetlib3

Python Telnet server and client Protocol library using asyncio
Other
144 stars 32 forks source link

Add handler for COM-PORT-OPTION subnegotiation #57

Closed albireox closed 3 years ago

albireox commented 3 years ago

This PR addresses #56. It simply adds a handler for the COM-PORT-OPTION subtransaction that currently is unhandled and raises an exception.

I'm not doing anything with the bytestream from the transaction othern than logging it.

Something that would require more refactoring but that could be useful is to expose fn_call as a module variable so that people and modify the dictionary to add/replace the handlers, or some othe mechanism to override the default fn_call.

jquast commented 3 years ago

Hey this is really sweet, thank you, I agree that there needed to be some callback for downstream, there is at least one idea in DESIGN.rst here about that. Sorry I wrote this so long ago, nobody likes to see their own design after years pass :)

jquast commented 1 year ago

sorry that i think it took a long time to just release this to pypi today, 2.0.0