jquast / wcwidth

Python library that measures the width of unicode strings rendered to a terminal
Other
393 stars 58 forks source link

Non-bugfix about zero & wide definition conflicts (again!) #110

Closed jquast closed 8 months ago

jquast commented 8 months ago

In this update to update-tables.py, 04d6d90ca4a7c3aef1a5a156b277ac9da79abb3a I wrote,

verify-table-integrity.py exercises a "bug" of duplicated tables that has no effect, because wcswidth() first checks for zero-width, and that is preferred in cases of conflict. This PR also resolves that error of duplication.

In that change I used method set.discard() in error, the discard method takes a single item as an argument, while I was providing using a whole set and so it had no effect. Instead, I now use set.difference() to re-assign the set value.

Also,

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0ba0278) 100.00% compared to head (594fc27) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #110 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 5 5 Lines 105 105 Branches 25 25 ========================================= Hits 105 105 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.