Closed jquast closed 1 year ago
This pull request introduces 1 alert and fixes 2 when merging b0dad96ab74c0630c9085aabff0c3acd06af233e into 4d4548048275ee25ba698cb0bd411296ff3f2238 - view on LGTM.com
new alerts:
fixed alerts:
This pull request fixes 2 alerts when merging bbe041b7112d0b8cbdd4f0990863c1ce2b6ef378 into 4d4548048275ee25ba698cb0bd411296ff3f2238 - view on LGTM.com
fixed alerts:
This pull request fixes 2 alerts when merging c161f925dda44fe1ea75993f810721e7fd4e1c3b into 4d4548048275ee25ba698cb0bd411296ff3f2238 - view on LGTM.com
fixed alerts:
This pull request fixes 2 alerts when merging 5e4ae4a0548b8f5ee3403b1b115e8b80f826678e into 4d4548048275ee25ba698cb0bd411296ff3f2238 - view on LGTM.com
fixed alerts:
thanks for the help, I'll merge & release in ~8 hours or so, I just want to be sure I am home to address any issues in release, and maybe address a few small open issues as well, #22, #24, #55, #56.
Thanks for your efforts! Everything LGTM. Updating to python 3.11 in tox.ini can be done in another PR.
With any luck I will be able to work on Cythonification tomorrow, I found this stack overflow solution that addresses my concern, that we can include a cython or c extension as optional and fallback to pure python if it is not able to compile, https://stackoverflow.com/questions/41778153/compiling-an-optional-cython-extension-only-when-possible-in-setup-py
This anwser looks really old, we have pyproject.toml
and PEP 517 nowadays. The get_requires_for_build_wheel
hook and an in-tree build backend will be helpful. Please see: https://github.com/psycopg/psycopg/issues/471#issuecomment-1368531676. Also, I think it can be done in another PR.
tox.ini
,requirements*
filespip-compile
with "requirements.in" files to generate "requirements.txt" files.j2
) templating to generate code and documentation,--check-last-modified
will compare last-modified for redownloadfor wcwidth/table*.py
files