Closed jquast closed 11 months ago
Attention: 5 lines
in your changes are missing coverage. Please review.
Files | Coverage Δ | |
---|---|---|
wcwidth/emoji_zwj_sequences.py | 100.00% <ø> (ø) |
|
wcwidth/table_wide.py | 100.00% <ø> (ø) |
|
wcwidth/table_zero.py | 100.00% <ø> (ø) |
|
wcwidth/unicode_versions.py | 100.00% <ø> (ø) |
|
wcwidth/wcwidth.py | 94.68% <83.33%> (-5.32%) |
:arrow_down: |
:loudspeaker: Thoughts on this report? Let us know!.
Sorry, no need to review, I have been using this branch for multiple ideas. I will carve them into smaller PR's, beginning with the automatic tests.
I am just performing automatic tests against popular terminals, now, and committing their results, when I'm finished with that I'll start smaller PR's, thank you!
wcswidth()
for zero-width join characters such as used in emoji sequences, and variations such as emoji skin tone, as well as many other non-printable characters now correctly identified as zero-width.width()
, a copy ofwcswidth()
without the POSIX compliance to return total width of -1 for any C0 or C1 control characters, those characters measured as width 0 by this new function.Discussion,
idx
past the next character, assuming they are cojoined is very high-performing and easy to implementWork remaining,