deprecate the use of 'getch()'

jquast / x84

A python telnet/ssh server for modern terminals. In spirit of classic software such as ami/x, teleguard, renegade, iniquity.

http://x84.readthedocs.org/

Other

373 stars 56 forks source link

deprecate the use of 'getch()' #275

Closed jquast closed 9 years ago

jquast commented 9 years ago

This PR is broken -- the old getch() returned "None", and many supporting functions check is None and need to be changed to check != "" or simple truthy/falsey for length:

- inp = getch()
+ inp = term.inkey()
- if inp is not None:
+ if inp:

landscape-bot commented 9 years ago

Repository health decreased by 0.09% when pulling 1cb5f6b on deprecate-getch into 4c193a3 on master.

1 new problem was found (including 1 error and 0 code smells).
No problems were fixed.

landscape-bot commented 9 years ago

Repository health decreased by 0.06% when pulling a61df62 on deprecate-getch into 4c193a3 on master.

1 new problem was found (including 1 error and 0 code smells).
2 problems were fixed (including 0 errors and 0 code smells).