search

jquelin / dist-zilla-plugin-git

dist::zilla plugin to update your git repository after release
https://metacpan.org/release/Dist-Zilla-Plugin-Git
32 stars 31 forks source link

dirty_dir for Git::Commit #4

Closed apocalypse closed 13 years ago

apocalypse commented 13 years ago

Hello,

After talking with cjm because I wanted his ArchiveRelease plugin to also commit the tarball, I learned that I had to patch Git::Commit to do it. We realized it would be easier to generalize it to an entire directory, and I've cooked up this patch to do it. A test is included, but I couldn't figure out a way to inline the MyTestArchiver package into the testfile for "cleanliness"... Ohwell :)

Thanks again for looking into this! Please let me know if I missed anything or need to tweak something, I'll help out :)

apocalypse commented 13 years ago

After talking with CJM, we thought renaming the attr to "add_files_in" made more sense, and I tweaked the POD a bit.

Thanks :)

P.S. I didn't realize github automatically added my recent commit to this pull request, so sorry for the double-pull request :)

madsen commented 13 years ago

I've looked this over, and while it's not functionality I expect to use, the change seems ok to me.

jquelin commented 13 years ago

merged (some commits squashed) & released as v1.110500