jquense / react-big-calendar

gcal/outlook like calendar component
http://jquense.github.io/react-big-calendar/examples/index.html
MIT License
7.54k stars 2.2k forks source link

Luxon localizer should use LLL to format month instead of MMM #2599

Open rinick opened 1 month ago

rinick commented 1 month ago

Check that this is really a bug

Reproduction link

https://codesandbox.io/p/sandbox/friendly-margulis-n7mfrv?file=%2Fsrc%2Findex.js

Bug description

Luxon localizer use MMM to format month, this might work fine with language like English, but it doesn't work with all the languages, like Chinese the correct way is to use LLL

Expected Behavior

No response

Actual Behavior

No response

react-big-calendar version

1.12.1

React version

18.2

Platform/Target and Browser Versions

any browser

Validations

Would you like to open a PR for this bug?

cutterbl commented 1 month ago

Correct, which is why we have the various formats props. Please see the documentation for how you may override.

rinick commented 1 month ago

hmm, even there is a workaround, it doesn't mean the default behavior should not be improved.

cutterbl commented 3 weeks ago

@rinick Your right, and I apologize for being so hasty. Resubmit your PR, update your branch with latest from master, and I will more thoroughly review.