search

jquense / react-bootstrap-modal

React port of jschr's better bootstrap modals
Other
89 stars 51 forks source link

Modals broken due to breaking change in react-overlays dependency #28

Closed Pisi-Deff closed 8 years ago

Pisi-Deff commented 8 years ago

When trying to open a modal: Uncaught TypeError: Cannot read property 'modals' of undefined

Link to breaking code

return (type) => baseIndex[type] + (zIndexFactor * (BaseModal.manager.modals.length - 1));

Link to change in react-overlays

-Modal.manager = modalManager;
+Modal.Manager = ModalManager;
bel0v commented 8 years ago

Got this issue too

91Cola commented 8 years ago

me, too.

91Cola commented 8 years ago

or const baseModal = new _Modal2.default.Manager(); return baseIndex[type] + zIndexFactor * (baseModal.modals.length - 1);

91Cola commented 8 years ago

thanks