Closed atis-- closed 7 years ago
I'm glad someone has taken the time to work on this :)
Some thoughts:
What's the motivation behind removing the check for an existing getZIndex
on line 95?
getZIndex
is a module-wide variable and will be overwritten by each successive mounted Modal. The one declared by the Modal mounted last will then be used for all Modals.
If my assumption is correct that this.manager
/ref.props.manager
will refer to the same ModalManager instance for all Modals, then it might be better to:
getZIndex
check: getZIndex = getZIndex || (function () {
so that the function is declared only once and not overwrittenI agree on all points. Please see the updated version.
Ok, even better. Please check if the new change looks alright to you.
thanks!
a way to fix https://github.com/jquense/react-bootstrap-modal/issues/28