Doc is really not up to date ?

[manodupont]

So i looked into the code of the latest release,

there is no onEnter, onEntered, there is only onEntering.

There might be some other flaws... am i correct ?

[jquense]

everything looks up to date to me, both in the repo and on npm. I see all the exit and enter events in both places

[manodupont]

My point is, the doc says that, but the code is not there.

There is no onEnter and onEntered and onExit etc method in the code.

Sent from my iPhone

On Mar 10, 2017, at 13:17, Jason Quense notifications@github.com<mailto:notifications@github.com> wrote:

everything looks up to date to me, both in the repo and on npm. I see all the exit and enter events in both places

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/jquense/react-bootstrap-modal/issues/39#issuecomment-285743997, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHN6od3IKxIAJzUPOCg3OohpUSRiKlXBks5rkZOGgaJpZM4MZsN9.

[jquense]

yes there is? https://github.com/jquense/react-bootstrap-modal/blob/master/src/Modal.js#L197-L202

[manodupont]

Mmm i will check again but i ended up looking into the code to find them cause they weren't called. I only got onHide to call an handler.

Sent from my iPhone

On Mar 10, 2017, at 14:21, Jason Quense notifications@github.com<mailto:notifications@github.com> wrote:

yes there is? https://github.com/jquense/react-bootstrap-modal/blob/master/src/Modal.js#L197-L202

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/jquense/react-bootstrap-modal/issues/39#issuecomment-285760320, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHN6obhTTzlpAteG_UKt-zPfZFUJ_kmcks5rkaKwgaJpZM4MZsN9.

[jquense]

they are transition hooks, so they only fire if you have an animation