search

jquense / react-dom-lite

Tiny dom implementation using react-reconciler
246 stars 21 forks source link

upgrade to babel 7 #20

Closed jquense closed 6 years ago

jquense commented 6 years ago

been upgrading to babel 7, this was next :)

jquense commented 6 years ago

I also loosened the browsers a bit for more specific mobile ones as well as making sure closure wasn't including polyfills (for now)

ManasJayanth commented 6 years ago

@jquense Just noticed the rewritePolyfills set to true. Are GCC's polyfills any better? I'm assuming only the required polyfills are injected

jquense commented 6 years ago

So i set it to false because I noticed GCC adding them (which you can see as $jscomp.. in https://unpkg.com/react-dom-lite@0.3.0/lib/react-dom-lite.min.js) By default it does include certain polyfills and maybe we want them, but for now I think it makes more sense to have users provide them like React does, and maybe if not enough browsers support them switch strategies (like WeekMap) but for now I think it's ok for folks to include them themselves in this early stage