search

jquense / react-formal

Sophisticated HTML form management for React
http://jquense.github.io/react-formal
MIT License
526 stars 52 forks source link

fix: Clear errors after validation on submit #174

Closed taion closed 4 years ago

jquense commented 4 years ago

how hard would it be to write a test for this? Want to make sure this doesn't break quietly in the future

taion commented 4 years ago

@jquense i can look at tests, but can you confirm that this approach is okay with you?

jquense commented 4 years ago

ya LGTM

taion commented 4 years ago

@jquense i added a quick test. it's very unit-y and it's specifically focused on just this one state, but i think it should prevent regressions? wdyt

taion commented 4 years ago

༼ つ ◕_◕ ༽つ Give v2.1.2

jquense commented 4 years ago

done!