search

jquense / react-widgets

Polished, feature rich, accessible form inputs built with React
http://jquense.github.io/react-widgets/
MIT License
2.34k stars 395 forks source link

Fix time picker when min is specified in date picker #1091

Closed jyaoma closed 2 years ago

jyaoma commented 3 years ago

This attempts to fix the Issue that I've recently reported: https://github.com/jquense/react-widgets/issues/1089

I've implemented a new concept to TimeInput called RawTimeParts which is just the string version of TimeParts and made use of RawTimeParts when working directly with the input fields and handling change events.

Feel free to make changes to this or you can let me know if there are any issues!

jquense commented 3 years ago

hey thanks for the PR. I'm short on time at the moment so haven't been able to look over this!

ryanore commented 3 years ago

@jquense, I appreciate the the library and respect your time, of course. Do you have an ETA of when we could expect you to get around to this?

jquense commented 2 years ago

ok sorry folks i keep trying to find time to look at this. I've just had a chance to do a once over this. I think this may be too complicated for a fix, it adds a lot of code and is hard to follow. I don't think that's a reflection on quality, the problem is inherently complex. The underlying issue here is that TimeInput isn't actually supposed to accept a min or max...and given how complex a solution to that is i'm inclined to leave it that way, which is actually how native inputs work as well.