search

jquense / react-widgets

Polished, feature rich, accessible form inputs built with React
http://jquense.github.io/react-widgets/
MIT License
2.34k stars 395 forks source link

q: why 'react-widgets' package depends on '@types/classnames'? #1106

Closed ZuBB closed 2 years ago

ZuBB commented 2 years ago

Can you explain what was the motivation to add '@types/classnames' as a runtime dependency for a 'react-widgets' package?

if you need types for that package -- that dependency has to be moved to "devDependecies" section.

In the latest versions classnames package goes with its own version of types and it creates some confusion

Do I miss something?

source commit https://github.com/jquense/react-widgets/commit/a02861767ea3f758837b2dedaa24e087e8e96d5c

jquense commented 2 years ago

https://stackoverflow.com/questions/45176661/how-do-i-decide-whether-types-goes-into-dependencies-or-devdependencies?noredirect=1&lq=1

ZuBB commented 2 years ago

https://stackoverflow.com/questions/45176661/how-do-i-decide-whether-types-goes-into-dependencies-or-devdependencies?noredirect=1&lq=1

Ok, I got it. its a valid case. but what about 2nd thing

In the latest versions classnames package goes with its own version of types and it creates some confusion

?

jquense commented 2 years ago

ah if they started including types then yeah we should remove the DT types

ZuBB commented 2 years ago

had to say that I have found a workaround on my side how to overcome, so it is up to you what to do in this case (I realized it is not so easy as I thought)

in any case thanks for good support in a very timely manner

j2ghz commented 4 months ago

ah if they started including types then yeah we should remove the DT types

The package is now deprecated, can it be removed?