search

jquense / react-widgets

Polished, feature rich, accessible form inputs built with React
http://jquense.github.io/react-widgets/
MIT License
2.34k stars 395 forks source link

findDOMNode is deprecated in StrictMode - error #1137

Open CarelessCourage opened 1 year ago

CarelessCourage commented 1 year ago

Im getting this error with the combobox.

react_devtools_backend.js:4026 Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of Transition2 which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here:

image

bt commented 1 year ago

Odd, I just came across this too with <DropdownList>. Similar stack trace, however it's mentioned in #928 that it's closed as fixed? No commit mentioned though and it was back in 2021 so it should have already been pushed.

jquense commented 1 year ago

This is due to react-transition-group, I am going to try and work around it without breaking changes :/

bt commented 1 year ago

This is due to react-transition-group, I am going to try and work around it without breaking changes :/

Thanks for the quick reply. Would you mind sharing roughly what code uses this and maybe I'll have a look to see if I can help when I'm free?

jquense commented 1 year ago

You can search in the repo, but probable the SlideDownTransition component specifically

quinn commented 1 year ago

It looks like they may have added a workaround: https://github.com/reactjs/react-transition-group/blob/master/CHANGELOG.md#440-2020-05-05

FlashAmarillo commented 1 year ago

It looks like they may have added a workaround: https://github.com/reactjs/react-transition-group/blob/master/CHANGELOG.md#440-2020-05-05

how to add the useRef hook to the Combobox component to fix the same issue? @quinn

robahtou commented 5 months ago

running into this issue. any updates?