search

jquense / react-widgets

Polished, feature rich, accessible form inputs built with React
http://jquense.github.io/react-widgets/
MIT License
2.34k stars 394 forks source link

try adding nodeRef #1140

Open quinn opened 1 year ago

quinn commented 1 year ago

attempt to fix #1137

jquense commented 1 year ago

if this works seems good to me, any reason it's still in a draft?

quinn commented 1 year ago

@jquense looks like I need to refactor because its a class-based component.

bt commented 1 year ago

Is useRef the same as React.createRef?

You can use createRef in class-based components.

quinn commented 1 year ago

@bt yes, it is the same. I updated to use createRef. @jquense what is a good way to test this out?

jquense commented 1 year ago

Try running the docs but in strict mode?

bt commented 1 year ago

@quinn Did you have any luck?

astralmedia commented 1 year ago

Any movement on this? Would love to clean that last error up on my logs :)

quinn commented 1 year ago

@astralmedia PR should work, I haven't had a chance to run the docs in strict mode as advised

quinn commented 1 year ago

also, I can't see why the build failed? says, expired

quinn commented 1 year ago

getting this error when I try to run docs:

node:internal/crypto/hash:71
  this[kHandle] = new _Hash(algorithm, xofLen);
                  ^

Error: error:0308010C:digital envelope routines::unsupported
BubuMVX commented 9 months ago

Hi, can this PR be merged or does it needs more work? I face the issue it should be fixing