search

jquense / uncontrollable

Wrap a controlled react component, to allow specific prop/handler pairs to be uncontrolled
MIT License
200 stars 35 forks source link

fix: move `@types/react` to dev deps #58

Open kyletsang opened 1 year ago

kyletsang commented 1 year ago

Fixes #53 Closes #54

jquense commented 1 year ago

These are suppose to be in deps not dev deps...if anything they are peer deps. But if they aren't installed with the package the types don't work.

This isn't usually a problem since consumers install them also but then you are yoloing valid ranges

kyletsang commented 1 year ago

Hmm I figured consumers always have them downloaded themselves anyways. In that case, let's set it up as a peer dep with the optional flag for non-TS consumers?

HighLiuk commented 4 months ago

@kyletsang do you have any workaround for this? Cannot build Preact with React Bootstrap unless this gets merged

kyletsang commented 4 months ago

@kyletsang do you have any workaround for this? Cannot build Preact with React Bootstrap unless this gets merged

Sorry I don't have a workaround for this. @jquense would need to review again.