let/const consistency in README: let preference

jquense / yup

Dead simple Object schema validation

MIT License

22.72k stars 925 forks source link

let/const consistency in README: let preference #2227

Closed dearlordylord closed 2 months ago

dearlordylord commented 2 months ago

I noticed let and const are used interchangeably in README. For consistency, I'd like to propose to use either/or. The previous PR https://github.com/jquense/yup/pull/2226 was about changing all lets to consts

alexandermirzoyan commented 2 months ago

Why to use let if in the code snippets variables are not being changed?

dearlordylord commented 2 months ago

That's a big topic (why not use DeepReadonly<> for every structure then?), but the goal of the PR is consistency. There's a satellite PR that makes everything const. The point is that in the README, let and const are intermixed for no apparent reason.

jquense commented 2 months ago

thanks!