search

jquery-archive / css-chassis

An attempt at creating an open standard for both CSS and JavaScript UI libraries.
https://css-chassis.com
Other
351 stars 67 forks source link

Build: make JSCS and JSHint lint the grunt config too #103

Closed arthurvr closed 8 years ago

arthurvr commented 8 years ago

This makes JSHint and JSCS lint the files in tasks/ too. I asked this but seems like @arschmitz forgot it: https://github.com/jquery/css-chassis/pull/89#discussion_r32540343.

arthurvr commented 8 years ago

The CI failure is on master too.

arschmitz commented 8 years ago

@arthurvr looks good other then id prefer to update and not use one var any more.

arthurvr commented 8 years ago

not use one var any more.

I considered it unrelated to this PR, but yeah, updated now.

other then id prefer to update

Can you elaborate?

arschmitz commented 8 years ago

@arthurvr I just meant i would prefer to update jscs then leave one var. Thats all i have.

sfrisk commented 8 years ago

Hey @arthurvr, when you have a sec, could you update this with master?

arthurvr commented 8 years ago

Yep, I totally can! It'll have to wait ~2 weeks though. It's only a semicolon. On di 4 aug. 2015 at 06:39 Sarah Frisk notifications@github.com wrote:

Hey @arthurvr https://github.com/arthurvr, when you have a sec, could you update this with master?

— Reply to this email directly or view it on GitHub https://github.com/jquery/css-chassis/pull/103#issuecomment-127475581.

sfrisk commented 8 years ago

Oh if it is just that I will fix it. I didn't look to closely at what was causing it last night.

Sent from my iPhone

On Aug 4, 2015, at 2:05 AM, Arthur Verschaeve notifications@github.com wrote:

Yep, I totally can! It'll have to wait ~2 weeks though. It's only a semicolon. On di 4 aug. 2015 at 06:39 Sarah Frisk notifications@github.com wrote:

Hey @arthurvr https://github.com/arthurvr, when you have a sec, could you update this with master?

— Reply to this email directly or view it on GitHub https://github.com/jquery/css-chassis/pull/103#issuecomment-127475581.

— Reply to this email directly or view it on GitHub.