Viewport: Add breakpoint variables and use them

[geekman-rohit]

Adds Breakpoints variables and modifies typography to use them.

[geekman-rohit]

@sfrisk I pushed to the PR.

[geekman-rohit]

@sfrisk , @arschmitz I suggest we rename to $breakpoint-sm instead of $viewport as these are breakpoints.

[geekman-rohit]

viewport-xs-min : 0 // we wont use or declare this, its assumed viewport-sm-min : 401 viewport-md-min: 769 viewport-lg-min: 921 viewport-xl-min: 1201

if everyone approves to that I could make the change and update ? Update: The above mentioned will be variables we use.(other than xs-min which we wont explicitly specify) Our viewports will be: xs(default): 0-400 sm: 401-768 md: 769-920 lg: 921-1200 xl: 1201-

[geekman-rohit]

@cvrebert is that (my earlier comment ) what you were suggesting?

[cvrebert]

@geekman-rohit Yeah, pretty much. Although the minimums being odd numbers seems slightly weird.

[geekman-rohit]

@sfrisk , my point in meeting today exactly. min should start at 400, xs ending at 399.

[arschmitz]

@cvrebert i agree

[sfrisk]

Then do that.

[geekman-rohit]

@sfrisk any reviews on this?

[sfrisk]

@geekman-rohit - remove the changes on files that aren't on breakpoint.js and make sure it works with the latest version of master, since I'm pretty sure this branch is a bit out of date. Once that is done, I can pull in these changes.

[geekman-rohit]

@sfrisk I think this can go in now?

[sfrisk]

Bahhhhh, I missed a step when I merged this in. My bad guys.