search

jquery-archive / css-chassis

An attempt at creating an open standard for both CSS and JavaScript UI libraries.
https://css-chassis.com
Other
351 stars 67 forks source link

Build: delete moot `.DS_Store` file #108

Closed arthurvr closed 8 years ago

arthurvr commented 8 years ago

This file doesn't add any value and can be safely deleted. It's a file OS X creates to store things like the folder background image or the position of the folder on your desktop.

@arschmitz This should be in your global gitignore file, fix your Git setup :p

sfrisk commented 8 years ago

Do you want to add it to .gitignore ?

https://github.com/jquery/css-chassis/blob/master/.gitignore

arthurvr commented 8 years ago

Do you want to add it to .gitignore ?

https://github.com/jquery/css-chassis/blob/master/.gitignore

If you prefer that, yes, happy to.

Though in fact it doesn't deserve in our gitignore, this is the reason global gitignore files exist. If you want to maintain them all here we could as well pull in this whole list... WDYT @sfrisk?

sfrisk commented 8 years ago

Hrmm, point, and it doesn't seem like the other projects have this. But it would be useful to make sure it is harder to accidentally include this file, or that we are just more diligent in checking PRs.

arthurvr commented 8 years ago

But it would be useful to make sure it is harder to accidentally include this file, or that we are just more diligent in checking PRs.

Yes, and with for that exact same argument we can add add vim swap files, webstorm idea folders, Windows thumbs files, ... and a huge bunch of other things. That's the reason global ignore files exist ;)

cvrebert commented 8 years ago

Yes, and with for that exact same argument we can add add vim swap files, webstorm idea folders, Windows thumbs files, ... and a huge bunch of other things. That's the reason global ignore files exist ;)

Yes, but you're assuming that PR submitters are git-savvy, such that they know about global ignore files and took the time to set one up. IME, this is a bad assumption; I've seen numerous examples to the contrary.

arthurvr commented 8 years ago

On the meeting it was decided to land this, as it was discussed earlier already.

Yes, but you're assuming that PR submitters are git-savvy, such that they know about global ignore files and took the time to set one up. IME, this is a bad assumption;

IMHO this really fundamental part of a Git setup is pretty reasonable to expect from people. Just like we expect authors to setup their Git author data for the CLA.

cvrebert commented 8 years ago

Well, have fun asking folks to revise their PRs to remove random editor files in the future then. :wink: Hope it'll be a good use of y'all's time.

geekman-rohit commented 8 years ago

i agree with @arthurvr , there are a lot of such files in windows and linux too. I don't really think we should add it to gitignore, I too think just making sure such files don't get committed ought to be enough .

arthurvr commented 8 years ago

Well, have fun asking folks to revise their PRs to remove random editor files in the future then. Hope it'll be a good use of y'all's time.

Well, if we don't add it to the gitignore that happens indeed. But there's not really a way around that. If we'd add this one to gitignore, we will have just the same situation, but with other files.

cvrebert commented 8 years ago

we will have just the same situation, but with other files.

True, but I've found that the Pareto principle is pretty applicable in this case.