search

jquery-archive / css-chassis

An attempt at creating an open standard for both CSS and JavaScript UI libraries.
https://css-chassis.com
Other
351 stars 67 forks source link

Build: add accessibility testing #114

Open dylanb opened 8 years ago

dylanb commented 8 years ago

Fixes #99

arschmitz commented 8 years ago

@dylanb feel free to force push PR's instead of opening new ones for the same thing.

dylanb commented 8 years ago

wooo hooo! Build passed.

arschmitz commented 8 years ago

@dylanb my comment got lost when you updated but can axe-webdriver run on browserstack?

dylanb commented 8 years ago

@arschmitz there is no reason it should not run on browserstack - I have never set it up to run there - how do the browserstack tests run for chassis?

arschmitz commented 8 years ago

@dylanb there are none for chassis yet this is the first thing that would use it. Sorry i used "we" a bit ambiguously here it was more a general "jquery foundation" we. We have a browserstack account for all our CI cross browser testing so we should use that here as well.

dylanb commented 8 years ago

@arschmitz could we handle that as a separate issue? I will need some help getting browserstack set up.

arschmitz commented 8 years ago

@dylanb thats fine if its not a part of axe-webdriver already its probably going to need to be done there first i can probably help with that.

dylanb commented 8 years ago

@arschmitz that would be really awesome!

dylanb commented 8 years ago

@arschmitz I have renamed the axe grunt Webdriver plugin to grunt-axe-webdriver and made the appropriate changes to this PR. What else do I need to do to get this merged?

sfrisk commented 8 years ago

@arschmitz @dylanb Just checking to see what the current status of this PR is, and if there is anything that needs to be done on our end to get everything working.

dylanb commented 8 years ago

@sfrisk I am waiting on feedback from someone as to what I need to do to make this mergeable...bit-rot has caused it to get out of sync with other code changes but I can fix that quite quickly

sfrisk commented 8 years ago

Hey, @dylanb, I think this looks good (sorry about the late response), could you just merge latest master into this to make sure everything still runs? If it does, this PR should be good to go.

geekman-rohit commented 8 years ago

hey @dylanb updates? @sfrisk I think we should pull this is in before #140

sfrisk commented 8 years ago

@geekman-rohit I've been working on pulling it in, but there are some merge conflicts I need to deal with.