search

jquery-archive / css-chassis

An attempt at creating an open standard for both CSS and JavaScript UI libraries.
https://css-chassis.com
Other
351 stars 67 forks source link

[WIP] typography: added color variables #129

Closed xtina-starr closed 8 years ago

xtina-starr commented 8 years ago

fixes gh-119

coauthored with @theutahkate This is a work in progress. We were curious if there was anything else within the _typography component that we could convert to use variables.

jquerybot commented 8 years ago

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

:memo: Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.

If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

sfrisk commented 8 years ago

Just want to check to see how this is going, I know that @theutahkate was working on this Sunday of the jQuery Dev Summit.

geekman-rohit commented 8 years ago

also seems like @xtina-starr will need to sign the CLA http://contribute.jquery.org/CLA/

xtina-starr commented 8 years ago

I've signed it, but because I just have my first name on github it got flagged as a suspicion name. Last I checked someone was suppose to manually accept the CLA.

On Tuesday, October 27, 2015, Rohit Mulange notifications@github.com wrote:

also seems like @xtina-starr https://github.com/xtina-starr will need to sign the CLA http://contribute.jquery.org/CLA/

— Reply to this email directly or view it on GitHub https://github.com/jquery/css-chassis/pull/129#issuecomment-151609456.

Christina Thompson www.christinasthompson.com 305-801-6561

sfrisk commented 8 years ago

@xtina-starr I'll contact the people in charge of the CLA to deal with it.

theutahkate commented 8 years ago

Arg! Sorry. Yes, I have a bunch of work done on it, and have been slammed since I got back, so haven't touched it. I was intending to open a pr to replace @xtina-starr 's (since I can't push to her repo), which would get around the CLA problem for now, too. So let me do that, probably tonight.

On Tue, Oct 27, 2015 at 12:20 PM, Sarah Frisk notifications@github.com wrote:

@xtina-starr https://github.com/xtina-starr I'll contact the people in charge of the CLA to deal with it.

— Reply to this email directly or view it on GitHub https://github.com/jquery/css-chassis/pull/129#issuecomment-151615870.

sfrisk commented 8 years ago

Closing this in favor of the work continued in #134