search

jquery-archive / css-chassis

An attempt at creating an open standard for both CSS and JavaScript UI libraries.
https://css-chassis.com
Other
351 stars 67 forks source link

[WIP] Add jsass variables to typography #134

Closed theutahkate closed 8 years ago

theutahkate commented 8 years ago

fixes gh-119 replaces pr #129

coauthored with @xtinastarr

I believe the tags are the only ones left to do here.

jquerybot commented 8 years ago

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

:memo: Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.

If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

geekman-rohit commented 8 years ago

@arschmitz regarding the indentation not being validated, we will have to wait for grunt-jscs to update to version 2.5.1 of node-jscs before doing a version bump at our repo. https://github.com/jscs-dev/grunt-jscs/pull/104

Umm I correct myself: that commit was reverted it seems https://github.com/jscs-dev/node-jscs/commit/056770dd525397f947df1131982e0da9d41bcb73

sfrisk commented 8 years ago

Hey @theutahkate @xtinastarr! Just checking in on the status of this PR.

geekman-rohit commented 8 years ago

@theutahkate updates?

sfrisk commented 8 years ago

Haven't heard any status update on this in awhile, so I'm closing this.