Typography: Add Variables

jquery-archive / css-chassis

An attempt at creating an open standard for both CSS and JavaScript UI libraries.

https://css-chassis.com

Other

351 stars 67 forks source link

Typography: Add Variables #139

Closed geekman-rohit closed 8 years ago

geekman-rohit commented 8 years ago

Work in Progress

geekman-rohit commented 8 years ago

@sfrisk, @arschmitz , @kristyjy , I have left TODOs on things i am already planning to change. Please review the diff /existing typography styles and suggest what more can be moved to variables.

sfrisk commented 8 years ago

Looks good to me. @kristyjy, @arschmitz ?

thejdeep commented 8 years ago

A couple of helpful additions could be :

Considering optimization in rendering typography CSS ( text-rendering and font-smoothing )
Need for letter-spacing and word-spacing in h's
Defining styles for print media and not just screen

cvrebert commented 8 years ago

Considering optimization in rendering typography CSS ( text-rendering and font-smoothing )

Consider not messing around with font-smoothing: Please Stop "Fixing" Font Smoothing

cvrebert commented 8 years ago

I wonder whether this Android 2.3 bug report regarding text-rendering: optimizeLegibility is accurate.

geekman-rohit commented 8 years ago

@cvrebert. Agreed. Im totally against using font smoothing and test-rendering both.. Poor browser support and slowed down rendering.

geekman-rohit commented 8 years ago

@sfrisk Updated. Can go in now once you review