Colors: Initial pass on updated palette.

jquery-archive / css-chassis

An attempt at creating an open standard for both CSS and JavaScript UI libraries.

https://css-chassis.com

Other

351 stars 67 forks source link

Colors: Initial pass on updated palette. #140

Closed sfrisk closed 8 years ago

sfrisk commented 8 years ago

Need to fix a spacing issue, but basic pass at the colors. A codepen illustrating this palette can be found at http://codepen.io/sfrisk/pen/bbeec265547b3554d047c445da957c1c/

arschmitz commented 8 years ago

:+1: the colors look good i like them. Remember for previews we have view.css-chassis.com all you need to do is push to a branch in the main repo instead of your fork

sfrisk commented 8 years ago

Yeah, it was more I didn't have a visual demo of these yet.

geekman-rohit commented 8 years ago

I think the colors are great. But they could be slightly darker to pass all WCAG tests. I suggest the following:

The base colors should pass all tests
The lighter ones may be allowed to fail the AAA tests for normal size but must pass all other
Colors in palettes like primary, success to be checked as background, with a white foreground
We should have a demo page so we can run accessibility testing on all colors in palette

cvrebert commented 8 years ago

Have y'all considered testing the distinguishability of the colors to people who are colorblind?

arschmitz commented 8 years ago

@cvrebert more then thought about https://github.com/jquery/css-chassis/pull/114

cvrebert commented 8 years ago

Ah, didn't know axe covered that. Neat.

sfrisk commented 8 years ago

Updated colors to reflect what is in the button PR. If that looks good, I'll merge it.