search

jquery-archive / css-chassis

An attempt at creating an open standard for both CSS and JavaScript UI libraries.
https://css-chassis.com
Other
351 stars 67 forks source link

Initial files and initial demo styles added #144

Closed nashvail closed 8 years ago

nashvail commented 8 years ago

For issue 10 : https://github.com/jquery/css-chassis/issues/10

geekman-rohit commented 8 years ago

@nashvail all your styles are direct css. Use some variables to make it easier to modify ur styles. Also discuss this sometime in a chassis meeting.

nashvail commented 8 years ago

Sorry for so many inconsistencies, just getting familiar with the code base. Hope the latest commit is compatible

sfrisk commented 8 years ago

@nashvail Looks like you're currently a few commits behind master, and you have some conflicts with master that need resolving. If you merge in master, you can look at the code for how we did buttons, to get an idea for how we expect variables to be used. As it is, I'm not sure using $primary makes sense for the hover state for these inputs.

screen shot 2016-03-09 at 1 48 30 pm

geekman-rohit commented 8 years ago

@nashvail please go through existing code to see how we declare varibles and where and when we do it. add a file in scss/variables for your input variables and use them in your scss. Things like box shadow should be variables making them easy to modify.

sfrisk commented 8 years ago

Could you please address the additional form elements in https://github.com/jquery/css-chassis/issues/6