search

jquery-archive / css-chassis

An attempt at creating an open standard for both CSS and JavaScript UI libraries.
https://css-chassis.com
Other
351 stars 67 forks source link

Tables: Table styling #151

Open kristyjy opened 8 years ago

kristyjy commented 8 years ago

This is a WIP pull request looking for feedback. I'd like to discuss if we should style the element like in this PR or make classes like the buttons PR did either here or in the meeting tomorrow.

jquerybot commented 8 years ago

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

:memo: Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.

If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

geekman-rohit commented 8 years ago

@kristyjy can you get @subaha to sign our CLA?

geekman-rohit commented 8 years ago

@kristyjy , could use more variables, especially with colors.

cvrebert commented 8 years ago

table { width: 100%; would almost certainly break some third-party widgets. I'd argue for moving the width declaration within a class.

sfrisk commented 8 years ago

@geekman-rohit @kristyjy At one point the CLA was valid. Not sure why it isn't anymore: https://github.com/jquery/css-chassis/pull/130

sfrisk commented 8 years ago

Screenshot of design: screen shot 2016-05-17 at 2 17 47 pm

sfrisk commented 8 years ago

Do we have a full width table option?

sfrisk commented 8 years ago

Tables can currently be viewed up in: http://view.css-chassis.com/53-tablestyles/demos/tables.html

Based on a discussions in today's meetings: What are thoughts about classes on all of the things? Do we want to require classes on every element (as the demo currently shows), or for a base level table, styling base and is acceptable?

cvrebert commented 8 years ago

One thing to consider is the effect on nested tables, which the designer might want to style differently from the ancestor table, so it's bad if the styles "bleed" into descendant tables. Bootstrap got complaints about this. (Thus, descendant selectors should be avoided in table styles.)

sfrisk commented 8 years ago

@cvrebert, I agree that's been something I've struggled with. @kristyjy has adjusted pr so descendent selectors are avoided.

jsf-clabot commented 7 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.