Open nashvail opened 8 years ago
<input>
s by default will break various third-party widgets.I agree with @cvrebert - this is something we had discussed in the meeting about how styling default could break 3rd party items.
Is the demos/inputs/inputs.css file necessary
? Looks empty. Also is there a reason for choosing to put input in its own folder?
Regarding the sizes, perhaps use maps so that users can add additional sizes just by adding entries to the maps?
For Reviewing: http://view.css-chassis.com/input-styling/demos/inputs.html
@kristyjy @geekman-rohit @arschmitz
You can view these changes at: http://view.css-chassis.com/input-styling/demos/inputs.html
Hey your tests are failing. "There is an extra comma following the final element of an array or object literal at scss/variables/inputs.js."
Normalize has been pulled in, which should fix some layout issues. Could you please rebase those changes into your develop branch.
@sfrisk sure!
I have rebased with the master branch. Please approve that the layout issues are fixed and I will squash and push the commits as one
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).
:memo: Please visit http://contribute.jquery.org/CLA/ to sign.
After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.
If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.