search

jquery-archive / css-chassis

An attempt at creating an open standard for both CSS and JavaScript UI libraries.
https://css-chassis.com
Other
351 stars 67 forks source link

Typography and Unit Measurement Review and Refactor #172

Open sfrisk opened 7 years ago

sfrisk commented 7 years ago

CSS best practices have changed a bit since we started this project. Along that line I think we should review how we've done typography so far in this project and how we can best refactor it to match best standards. Specifically there is a lot of px useage for size/measurements, and we have a em convertor when we could probably be using rem instead. Same thing holds true with a lot of measurements for components that have been created - overuse of the px measurement unit.

lunaticmonk commented 7 years ago

We have used em for typography. Can't we used rem for that instead of em? Wouldn't that prove good? According to me using em would cause problems when 2-3 elements are nested.For example nested unordered lists. Opinions?

lunaticmonk commented 7 years ago

@sfrisk I am refactoring typography. I want to use rem instead of em. The _typography.scss file has all the values of typography defined in pixels....shall I keep them in pixels as it is? Since the pixel to rem converting function will take care of final conversion to rem format.

sfrisk commented 7 years ago

check out https://www.youtube.com/watch?v=XanhwddQ-PM - this shows a lot of the techniques we were planning on applying to typography, and unit measurement in general for Chassis.