search

jquery-archive / css-chassis

An attempt at creating an open standard for both CSS and JavaScript UI libraries.
https://css-chassis.com
Other
351 stars 67 forks source link

Typography: change the unit measurement from 'em' to 'rem' #174

Open lunaticmonk opened 7 years ago

lunaticmonk commented 7 years ago

I tried to refactor the code and changed the em converter to rem since it would be better to use rem. em would cause problems when 2-3 elements are nested. Opinions?

geekman-rohit commented 7 years ago

@sumedh123 just changing the unit will not suffice in our case. It's not so much change the unit that we wish to do, but change the approach entirely. This will most probably mean a major code change and a change/removal of the em mixin we are using

geekman-rohit commented 7 years ago

The changes I requested all need discussion, but they need to be discussed before we merge any more PRs