Performance: Add topcoat framework to test suite

jquery-archive / css-chassis

An attempt at creating an open standard for both CSS and JavaScript UI libraries.

https://css-chassis.com

Other

351 stars 67 forks source link

Performance: Add topcoat framework to test suite #45

Closed geekman-rohit closed 9 years ago

geekman-rohit commented 9 years ago

Added topcoat framework to the test suite It is tested for following types of buttons

button
button - large
button -quiet
button- large and quiet
button - cta( click to action )
button large and cta
icon button (/large/quiet)
button with icons

arthurvr commented 9 years ago

This whole PR uses the wrong indentation. We use tabs.

arschmitz commented 9 years ago

Everything i commented on mobile also applies to desktop version

arschmitz commented 9 years ago

Also please run grunt before doing updates again much of this would have been caught by jshint and jscs

arthurvr commented 9 years ago

All code styling is addressed! Thanks @geekman-rohit!

arschmitz commented 9 years ago

@geekman-rohit this look good the only last thing is for future PR's take a look at http://contribute.jquery.org/commits-and-pull-requests/#commit-guidelines The first commit conforms and i'm going to squash these all to one commit anyway so ill just land this one.

geekman-rohit commented 9 years ago

@arschmitz , I had been through it, but I was not careful enough with minor things like spaces. now I understand the readability the extra spaces is going to give the code. Will be more careful in future PRs. Thanks for landing it, and for putting up while I got used to your coding standards.