jquery-archive / jquery-mobile

jQuery Mobile Framework
https://jquerymobile.com
Other
9.7k stars 2.41k forks source link

Collapsible block prevents page scrolling on iPhone 4 #1157

Closed piotr-shalatonin closed 13 years ago

piotr-shalatonin commented 13 years ago

Steps: 1) Goto page http://jquerymobile.com/demos/1.0a3/#docs/content/content-collapsible.html . 2) Touch surface of the collapsible section header. 3) Move up fingertip over surface without losing contact.

Expected behavior: page scrolls. Result behaviour: collapsible block expands, page doesn't scroll.

scottjehl commented 13 years ago

Fixed in latest. Confirmed on iOS 3.2 4.3. Thanks!

piotr-shalatonin commented 13 years ago

It seems that in alpha 4.1 I see this issue: 1) Goto page http://jquerymobile.com/demos/1.0a4.1/#docs/content/content-collapsible.html 2) Touch surface of the collapsible section header (with state "collapsed"). 3) Move up fingertip over surface without losing contact. Expected behavior: page scrolls, block state is "collapsed". Result behaviour: collapsible block expands, page scrolls.

jblas commented 13 years ago

Fixed the issue @spvlog mentioned above.

https://github.com/jquery/jquery-mobile/commit/7d9af0b2a8589953524b9f2dfc3895af12177e1e

The bug resurfaced because I just did a straight translation of the events used to the new virtual mouse events. This meant that the collapsible was expanding/collapsing on vmouseup, but to factor in scrolling, we actually needed to move that code to vclick.

piotr-shalatonin commented 13 years ago

Confirm fixed. Thanks!