search

jquery-archive / jquery-mobile

jQuery Mobile Framework
https://jquerymobile.com
Other
9.68k stars 2.4k forks source link

Buttons in the controlgroup label #5352

Closed aristotelos closed 11 years ago

aristotelos commented 11 years ago

Buttons in the controlgroup label are styled as if they are part of the controlgroup controls.

This can be fixed by two modifications to the code: Add an extra statement after the wrapping:

    $el.wrapInner("<div class='ui-controlgroup-controls'></div>");
    groupcontrols = $el.children(".ui-controlgroup-controls");

Apply the initialize on the groupcontrols childs instead of on the $el childs:

    flipClasses(groupcontrols.find(".ui-btn" + (o.excludeInvisible ? ":visible" : "")).not('.ui-slider-handle'), flCorners);
    flipClasses(groupcontrols.find(".ui-btn-inner"), flCorners);
jaspermdegroot commented 11 years ago

@aristotelos

We made a lot of changes to controlgroup. These changes are in latest code on branch master and will land in 1.3. The code you are referring to is no longer there. We don't use the JS for corner styling anymore, but do this with CSS only.

I am closing this issue. If you still see a problem with latest code, please comment and we will reopen. Thanks!

aristotelos commented 11 years ago

See this reproduction: http://jsbin.com/onibuc/383/

jaspermdegroot commented 11 years ago

@aristotelos

In this case you'll have to use a div: http://jsbin.com/onibuc/409/edit

aristotelos commented 11 years ago

@uGoMobi Good suggestion, but I am using "fieldcontain" wrappers. See http://jsbin.com/onibuc/412/