search

jquery-archive / jquery-mobile

jQuery Mobile Framework
https://jquerymobile.com
Other
9.69k stars 2.4k forks source link

All: Deprecate portions of initSelector that are not "[data-ui-role='<widgetname>']" #7940

Closed gabrielschulhof closed 8 years ago

gabrielschulhof commented 9 years ago

Place comments in the code of the form

// The default value of initSelector is DEPRECATED as of 1.5.0 and will be removed in 1.6.0

before each initSelector declaration.

Make sure that it is clear that initSelector itself is not deprecated and that it will continue to be honoured in future versions, only that it will be set to [data-ui-role="<widgetname>"] by default for all widgets.

gabrielschulhof commented 9 years ago

See also https://github.com/jquery/api.jquerymobile.com/issues/353

gabrielschulhof commented 9 years ago

See also https://github.com/jquery/jquerymobile.com/issues/113

ray007 commented 9 years ago

I guess that means selectmenu will also get a less greedy initSelector? Something like "select:not(:jqmData(role)), select:jqmData(role=selectmenu)"?

arschmitz commented 9 years ago

@ray007 the init selector for selectmenu will be [data-ui-role='selectmenu'] after this change

apsdehal commented 8 years ago

@arschmitz I guess this can be closed now.