jquery-archive / jquery-mobile

jQuery Mobile Framework
https://jquerymobile.com
Other
9.69k stars 2.4k forks source link

Selectmenu non-native theming problem #7957

Closed slavap closed 8 years ago

slavap commented 9 years ago

Test case: http://jsbin.com/husohaluqo/1/edit?html,css,js,output

Page theme "a", header theme "b", selectmenu on header. If no theme explicitly defined for selectmenu it will be styled as parent (header). But popup is styled incorrectly as "a" (page).

Also it would be nice to have separate option for popup styling, because often it should be styled quite differently.

jaspermdegroot commented 9 years ago

This is not a bug in the framework, but something we should probably document better. Custom selects use the popup widget for the menu. Because the popup container is elsewhere on the page it can't inherit the theme swatch from the parent of the select, and inherits from the page instead. This is documented for popup but not in the selectmenu API docs.

slavap commented 9 years ago

Thanks for clarification, though it looks very strange, and enforces always to specify theme explicitly for selectmenus on header. What about implementing separate option in selectmenu for popup styling?

jaspermdegroot commented 9 years ago

@slavap

What about implementing separate option in selectmenu for popup styling?

You can style the selectmenu popup. See http://jsbin.com/qavisoxaro/1/edit?html,output

slavap commented 9 years ago

data-overlay-theme="none" removes/changes style for "fading" cover. But popup with list items itself is not changing. It's not possible to define theme "b" for selectmenu and for example theme "c" for its selection popup.

marti1125 commented 8 years ago

Hi @jaspermdegroot any update ? Can I help you?

jaspermdegroot commented 8 years ago

hi @marti1125

Help is always welcome! If you can open a PR in the https://github.com/jquery/api.jquerymobile.com repo to make the changes as I described in my comment https://github.com/jquery/jquery-mobile/issues/7957#issuecomment-75123138 above that would be great! Thanks!

marti1125 commented 8 years ago

Hi @jaspermdegroot I'm trying to deploy api.jquerymobile.com but I have error with grunt taks. When I run grunt deploy I get an error about Running "build-xml-entries:all" (build-xml-entries) task

captura de pantalla 2016-03-25 a las 23 33 17

I added in Mac OS: libxml2 and libxslt I used this instructions http://ripary.com/libxml2_leopoard.html

jaspermdegroot commented 8 years ago

@marti1125

Yeah, I did hear about problems with deploying the API docs. I think they were fixed by now, but I am not sure to be honest. If you still encounter problems please open a ticket at the API docs repo so the people that are looking into this will be aware of it.

agcolom commented 8 years ago

@marti1125 @jaspermdegroot Yes, this issue around the deployment of the api docs was fixed by https://github.com/jquery/api.jquerymobile.com/commit/c9950027ed101b74c94084f02b39c29e5ba8441a#diff-b9cfc7f2cdf78a7f4b91a753d10865a2 and https://github.com/jquery/jquery-wp-content/commit/836858d66f9833dfc02b00c393bdca848acb1205

jaspermdegroot commented 8 years ago

@agcolom

That's great. Thanks for the update!

marti1125 commented 8 years ago

@agcolom thanks!!

marti1125 commented 8 years ago

Hi @jonathansampson could you check my PR please =D