jquery-archive / plugins.jquery.com

The jQuery Plugins site
plugins.jquery.com
Other
1.24k stars 243 forks source link

Changing the version number in the URL has unexpected behavior #108

Closed mattsnider closed 11 years ago

mattsnider commented 11 years ago

I recently added a new plugin:

http://plugins.jquery.com/queryParser/1.0.0/

It mostly worked as expected when I added it, but I realized I forgot my email, so I create version 1.0.1, tagged, and repushed. While I was waiting for the plugin site to publish my changes I modified the URL of the plugin to see if my changes were available yet:

http://plugins.jquery.com/queryParser/1.0.1/

Unexpectedly, I was redirected to the following URL, instead of getting a 404 error:

http://plugins.jquery.com/slashSearch/1.0.1/

ajpiano commented 11 years ago

Confirmed. Perhaps this is some really overzealous behaviour of the url autocorrection in WordPress?

Mottie commented 11 years ago

I just wanted to include a note here to make sure to strip off the v prefix from the tag. It is allowed per the semver spec, but may make it difficult to find older versions if you don't know which tag has the prefix.

scottgonzalez commented 11 years ago

@Mottie The version number, not the tag, is what ends up in the URL. Version numbers cannot contain the v prefix.

scottgonzalez commented 11 years ago

Fixed in jquery/jquery-wp-content@a9c42e425f95221e0e5820fa7307eba44194ba14.

mattsnider commented 11 years ago

Has this change been deployed yet. I changed the version # to 1.0.2 and got this URL

http://plugins.jquery.com/chaperone/1.0.2/

Instead of a 404 or message that the version doesn't exist.

scottgonzalez commented 11 years ago

Not yet.