search

jquery / 2012-dev-summit

Information regarding the 2012 Developer Summit in DC
14 stars 14 forks source link

Update the Pull Requests wiki page #46

Closed rdworth closed 12 years ago

rdworth commented 12 years ago

http://wiki.jqueryui.com/Pull-Requests

Perhaps other wiki pages need updating as well, to reflect our current processes

jzaefferer commented 12 years ago

We should rewrite the entire "How to edit a commit or squash multiple commits" section. Cherry-picking with amending, without the "-n" option, is much easier then looking up the author and committing from scratch. And for squashing commits or editing older commits, using interactive rebase is much more powerful. @scottgonzalez any objections?

scottgonzalez commented 12 years ago

Sounds good. We need to make sure to include a note about verifying that we have a CLA and the author info in git is correct.

jzaefferer commented 12 years ago

Updated! I'm not really sure how to properly verify CLA and author info. Can you add that?

scottgonzalez commented 12 years ago

I added a comment on the wiki page, we should just get automated PR testing working and have that validate author info.