search

jquery / 2015-developer-summit

a sandbox site for making mistakes
http://jquery.github.io/2015-developer-summit/
MIT License
10 stars 26 forks source link

add bootstrap to local dir #10

Open aricearice opened 8 years ago

aricearice commented 8 years ago

Should fix issue #1

gnarf commented 8 years ago

There seem to be merge conflicts here, can you update the branch?

aricearice commented 8 years ago

@gnarf updated and fixed conflicts

gnarf commented 8 years ago

Awesome! I'm +1 here, lets find 2 more to approve per contributing rules

ashleygwilliams commented 8 years ago

hi! i actually think this may not be the best solution to the problem. the repo currently manages packages with npm. we should be using the node_modules files, or we should remove the package manager altogether. personally i think using a manager is a better choice.

ajpiano commented 8 years ago

:+1: to @ashleygwilliams - we def should reference the npm files

gnarf commented 8 years ago

For bootstrap css? Do they even ship that on npm? ¯\_(ツ)_/¯

gnarf commented 8 years ago

@ashleygwilliams - I suppose it's a better practice moving forward, I'm a dinosaur tho and didn't figure the bootstrap css would get used from node_modules.

Also, since we shouldn't commit the node_modules that means that the output of the npm install would need to copy the built file to some place like public and have it committed and served in this fashion anyway. gh-pages hosts don't npm install

Perhaps just adding a "postinstall": "cp node_modules/boostrap/...min.css public/css" in the package.json scripts section would work, but I don't know how windows users would handle that.