Open aricearice opened 8 years ago
There seem to be merge conflicts here, can you update the branch?
@gnarf updated and fixed conflicts
Awesome! I'm +1 here, lets find 2 more to approve per contributing rules
hi! i actually think this may not be the best solution to the problem. the repo currently manages packages with npm. we should be using the node_modules
files, or we should remove the package manager altogether. personally i think using a manager is a better choice.
:+1: to @ashleygwilliams - we def should reference the npm files
For bootstrap css? Do they even ship that on npm? ¯\_(ツ)_/¯
@ashleygwilliams - I suppose it's a better practice moving forward, I'm a dinosaur tho and didn't figure the bootstrap css would get used from node_modules
.
Also, since we shouldn't commit the node_modules
that means that the output of the npm install
would need to copy the built file to some place like public
and have it committed and served in this fashion anyway. gh-pages hosts don't npm install
Perhaps just adding a "postinstall": "cp node_modules/boostrap/...min.css public/css"
in the package.json
scripts
section would work, but I don't know how windows users would handle that.
Should fix issue #1