jquery / codeorigin.jquery.com

jQuery CDN
https://releases.jquery.com
Other
57 stars 605 forks source link

Build: List jQuery Core module files if present #97

Closed mgol closed 5 months ago

mgol commented 10 months ago

Note that this does not add factory files - they are meant for Node.js so we don't plan to upload them to the CDN, just make them available in the npm package (and the bower one but that's just because contents are the same).

mgol commented 10 months ago

For now, the module files only exist for the Git builds as they will only be available starting with jQuery 4.0.0. Those already exist so you can check them.

Krinkle commented 10 months ago

For "slim", we label it "slim" and "slim minified", with a space instead of parenthesis. I tend to avoid parenthesis in navigational links when possible, to make it feel less complex to the reader.

Today:

uncompressed, minified, slim, slim minified.

If we follow the wording for "slim":

uncompressed, minified, slim, slim minified, module, module minified, slim module, slim module minifed.

With more labels and parenthesis:

uncompressed, minified, slim (uncompressed), slim (minified), module (uncompressed), module (minified), slim module (uncompressed), slim module (minifed).

Vertical separation:

script: uncompressed, minified, slim, slim minified module: uncompressed, minified, slim, slim minified.

Note that this does not add factory files - they are meant for Node.js so we don't plan to upload them to the CDN, just make them available in the npm package […]

Hm.. in that case, do we need the above logic? Or would we only need the -git links in that case, which are a separate part of the patch afaik. The above is only applied to CDN and stable releases, right?

mgol commented 10 months ago

@Krinkle We don't plan to upload factory files:

or Node module wrapper files:

We do plan to upload module files:

so yes, this additional logic is needed.

The list gets quite long now so I like the vertical separation idea. I'll need to refactor the code a bit for that.

mgol commented 6 months ago

PR updated. The latest state of the home page limited to the jQuery Core section:

Screenshot 2024-01-27 at 00 45 43

and the jQuery Core page itself:

Screenshot 2024-01-27 at 00 45 27

I changed hyphens to colons universally as hyphens look bad in the multiline setup and IMO it's better to settle on one for consistency.

mgol commented 5 months ago

This change is still not deployed at https://releases.jquery.com/jquery/. I tested it locally and it worked. Any ideas?

mgol commented 5 months ago

Actually, no commit since https://github.com/jquery/codeorigin.jquery.com/commit/53da21880f4d29f46feccc5577fb36b988b180ab is getting deployed. I posted on #jquery-infra on Slack.