search

jquery / contribute.jquery.org

Developer documentation common to jQuery projects
https://contribute.jquery.org
Other
25 stars 76 forks source link

CSS Style Guide - Add !important notice #103

Closed sfrisk closed 9 years ago

sfrisk commented 9 years ago

Added the !important rule to csslint as suggested in #96. However, since this is currently not standard practice, additional issues will need to be created in other projects to add this to the project's csslint file.

UI and Mobile currently contain !important in the css, so that css will need to be refactored to not need !important in order for new csslint rules to pass.

arschmitz commented 9 years ago

The only thing i'm not 100% sure about is changing the csslint setting since i'm not 100% sure the one use in UI can actually be avoided. Mobile really needs to be cleaned up but we can likely wait on that for when we adopt chassis. Overall i'm :+1:

sfrisk commented 9 years ago

Yeah, I might take out the csslint bit, just because I'm pretty sure right now it would not pass, but it is something I would like to require in Chassis.

arschmitz commented 9 years ago

So to argue against myself here i think this should go in the .csslint settings. We have plenty of old code in both ui and mobile ( and i'm going to guess core too ), that does not conform to the current style guide. That does not however mean we should not enforce future code to which is why these things are still in the style guide.

arthurvr commented 9 years ago

Yeah, I agree with @arschmitz last comment. What do we think? Is this PR good to land?

scottgonzalez commented 9 years ago

Seems good to me. We'll just leave that one rule out of existing projects that don't currently conform and file issues to resolve.