Open scottgonzalez opened 9 years ago
I dislike it. It seems like something is missing. It seems like someone just forgot to indent it.
My vote goes for either @dmethvin suggestion A or @scottgonzalez suggestion B.
A:
this.tabs.filter( function() {
return $( this ).attr( "tabIndex" ) === 0;
} ).attr( "tabIndex", -1 );
B:
this.tabs.filter( function() {
return $( this ).attr( "tabIndex" ) === 0;
} )
.attr( "tabIndex", -1 );
PS: The spacy } )
is really awkward. I couldn't get used to it yet :see_no_evil:.
A is definitely not in line with our style guide. B is actually what I expected. See the other thread for @jzaefferer's explanation of why he didn't want the extra indentation.
From https://github.com/jquery/jquery-ui/pull/1508#issuecomment-86893279:
Example:
Any arguments against this?