search

jquery / contribute.jquery.org

Developer documentation common to jQuery projects
https://contribute.jquery.org
Other
25 stars 76 forks source link

New HTML Style Guide #117

Closed handasolo closed 8 years ago

arthurvr commented 9 years ago

Common knowledge but worth emphasizing, the order of the charset declaration and the <title> is important.

arthurvr commented 9 years ago

Thanks for the hard work on this, @Slayslot!

handasolo commented 9 years ago

It's a pleasure @arthurvr :D and how can I remove the CLA:Error? I did sign it.

handasolo commented 9 years ago

And a note on the second commit: Any bad examples that I didn't remove, I believe that either they are common problems that should be mentioned or that without those bad examples the section wouldn't be understood as well. For eg: The separation of concerns section wouldn't be understood as good as it is with the bad example.

arthurvr commented 9 years ago

@Slayslot The CLA check fails because you don't have your full name in your git config (currently you only have your username). Please see contribute.jquery.org on how to update your git config.

handasolo commented 9 years ago

About the CLA Error, I did update my git config and according to the commit log the latest commit carries the correct config and the first one has my name as 'Slayslot' and that did not change with the method provided.

arthurvr commented 9 years ago

This PR is meant to fix https://github.com/jquery/contribute.jquery.org/issues/92.

handasolo commented 9 years ago

@arthurvr Anything I can do to get this merged?

handasolo commented 8 years ago

Sorry about the CLA: Error reoccurring. I forgot that the last time I pushed on the repository I was using Windows. When I pushed the commit from linux it used my default username. Anyhow, please let me know if there are any further changes required.

handasolo commented 8 years ago

Still willing to get this merged. Please let me know if there are any changes required here. @arthurvr @sfrisk @scottgonzalez . Thanks.

handasolo commented 8 years ago

Updated. Sorry for the bad commit name, couldn't think of anything better :|

handasolo commented 8 years ago

@scottgonzalez Would love it if you can review this. Apologies that this one PR has taken so long.

scottgonzalez commented 8 years ago

Just one minor issue remaining.

scottgonzalez commented 8 years ago

I can fix that issue when I merge this.