search

jquery / download.jqueryui.com

Download Builder for jQuery UI
https://jqueryui.com/download/
Other
86 stars 72 forks source link

Starting with saved theme URL and applying gloss_wave background loses all settings #594

Open roberto-cisternino opened 2 years ago

roberto-cisternino commented 2 years ago

Description

If I retrieve the ui url from the css header (see below links) and I try to edit the background of a style by applying the gloss_wave, I loose most of the style and I obtain a rendering based on the default theme.

If the url comes from an old theme version it is rendered correctly but cannot be modified (see the above explanation) If I "save as" the current theme with the latest version, the link available on the theme css do not produce the expected theme but always the default theme.

A downloaded theme do not take into consideration a scope (if, any) because the index.html should associate to the body a class with the scope name.

In general, at this stage, the theme roller is unusable.

Link to test case

The below theme urls should be equivalent.

This is a 1.11.4 custom theme (this works but cannot be modified):

http://jqueryui.com/themeroller/?ffDefault=Arial%2CHelvetica%2Csans-serif&fsDefault=1em&fwDefault=normal&cornerRadius=0px&bgColorHeader=%23003587&bgTextureHeader=flat&borderColorHeader=%23003587&fcHeader=%23ffffff&iconColorHeader=%23b3d1ff&bgColorContent=%23ffffff&bgTextureContent=flat&borderColorContent=%239BB1D0&fcContent=%23333333&iconColorContent=%23b3d1ff&bgColorDefault=%23004EC5&bgTextureDefault=flat&borderColorDefault=%239BB1D0&fcDefault=%23fff&iconColorDefault=%23fff&bgColorHover=%231661d4&bgTextureHover=flat&borderColorHover=%239BB1D0&fcHover=%23fff&iconColorHover=%23fff&bgColorActive=%23becce0&bgTextureActive=flat&borderColorActive=%239BB1D0&fcActive=%23004EC5&iconColorActive=%234A5463&bgColorHighlight=%23fffa90&bgTextureHighlight=flat&borderColorHighlight=%239BB1D0&fcHighlight=%23000&iconColorHighlight=%23003587&bgColorError=%23fddfdf&bgTextureError=flat&borderColorError=%239BB1D0&fcError=%235f3f3f&iconColorError=%23cc0000&bgColorOverlay=%23aaaaaa&bgTextureOverlay=flat&bgImgOpacityOverlay=0&opacityOverlay=30&bgColorShadow=%23666666&bgTextureShadow=flat&bgImgOpacityShadow=0&opacityShadow=30&thicknessShadow=5px&offsetTopShadow=0px&offsetLeftShadow=0px&cornerRadiusShadow=8px&bgImgOpacityHeader=&bgImgOpacityContent=&bgImgOpacityDefault=&bgImgOpacityHover=&bgImgOpacityActive=&bgImgOpacityHighlight=&bgImgOpacityError=

This is the 1.13.1 version of the previous theme (this doesn't work at all):

http://jqueryui.com/themeroller/?scope=.sea&folderName=sea&bgImgOpacityError=&bgImgOpacityHighlight=&bgImgOpacityActive=&bgImgOpacityHover=&bgImgOpacityDefault=&bgImgOpacityContent=&bgImgOpacityHeader=&cornerRadiusShadow=8px&offsetLeftShadow=0px&offsetTopShadow=0px&thicknessShadow=5px&opacityShadow=30&bgImgOpacityShadow=0&bgTextureShadow=flat&bgColorShadow=%23666666&opacityOverlay=30&bgImgOpacityOverlay=0&bgTextureOverlay=flat&bgColorOverlay=%23aaaaaa&iconColorError=%23cc0000&fcError=%235f3f3f&borderColorError=%239BB1D0&bgTextureError=flat&bgColorError=%23fddfdf&iconColorHighlight=%23003587&fcHighlight=%23000&borderColorHighlight=%239BB1D0&bgTextureHighlight=flat&bgColorHighlight=%23fffa90&iconColorActive=%234A5463&fcActive=%23004EC5&borderColorActive=%239BB1D0&bgTextureActive=flat&bgColorActive=%23becce0&iconColorHover=%23fff&fcHover=%23fff&borderColorHover=%239BB1D0&bgTextureHover=flat&bgColorHover=%231661d4&iconColorDefault=%23fff&fcDefault=%23fff&borderColorDefault=%239BB1D0&bgTextureDefault=flat&bgColorDefault=%23004EC5&iconColorContent=%23b3d1ff&fcContent=%23333333&borderColorContent=%239BB1D0&bgTextureContent=flat&bgColorContent=%23ffffff&iconColorHeader=%23b3d1ff&fcHeader=%23ffffff&borderColorHeader=%23003587&bgTextureHeader=flat&bgColorHeader=%23003587&cornerRadius=0px&fwDefault=normal&fsDefault=1em&ffDefault=Arial%2CHelvetica%2Csans-serif

mgol commented 2 years ago

Thanks for the report. Given limited team resources the issue is not likely to be fixed by the UI team; see the project status at https://blog.jqueryui.com/2021/10/jquery-maintainers-update-and-transition-jquery-ui-as-part-of-overall-modernization-efforts/. PRs are welcome if they're not too complex.

mgol commented 2 months ago

I've read this issue again and I have trouble understanding - what does the following mean?

I try to edit the background of a style by applying the gloss_wave

Themeroller allows to modify various background colors in the hex format. Where does this glossy_wave come into picture?