search

jquery / download.jqueryui.com

Download Builder for jQuery UI
https://jqueryui.com/download/
Other
86 stars 72 forks source link

Attempting to download customized theme #602

Closed Mark-Boyce closed 2 months ago

Mark-Boyce commented 9 months ago

After making a few customizations, attempting to download the theme results in a 404 error and the customizations are not downloaded.

mueslinibbles commented 8 months ago

Likewise, getting the same problem. Customise the theme then goto the download page and get a 'service unavailable' error Screenshot 2023-11-06 164804

Theme downloads, but devoid of any customised images/icon files.

mgol commented 8 months ago

@mueslinibbles @Mark-Boyce is the behavior reproducible? Does it happen all the time or periodically? Can you lay out very, very precise steps to reproduce? Exactly which URL you visit, what you click/type, step by step.

I need this as just if I try to change a few things, I can download the themed package without issues.

mueslinibbles commented 8 months ago

Yes, this is happening every time I try to download either the base theme, or a customisation of it. Simplest, repeatable, route to the error is;

  1. Goto https://jqueryui.com/
  2. Click 'Themes' from menu
  3. Goto the 'Gallery' tab of the ThemeRoller.
  4. Select the Base theme.
  5. Click the download button.
  6. The Download Builder window appears, then after a moment the 'service unavailable' 404 error box appears.

hope this helps.

mgol commented 8 months ago

Thank you! I can reproduce it now.

From what I see, there's a request triggered to https://download.jqueryui.com/download/theme?themeParams=ffDefault%3D... and that results in a 500 with the following stack trace:

Error: No dimensions set for texture "none"
    at ThemeRoller._textureUrl (/app/lib/themeroller.js:270:10)
    at new ThemeRoller (/app/lib/themeroller.js:160:29)
    at Frontend.theme (/app/download.js:195:20)
    at /app/server.js:97:35
    at Layer.handle [as handle_request] (/app/node_modules/express/lib/router/layer.js:95:5)
    at next (/app/node_modules/express/lib/router/route.js:137:13)
    at Route.dispatch (/app/node_modules/express/lib/router/route.js:112:3)
    at Layer.handle [as handle_request] (/app/node_modules/express/lib/router/layer.js:95:5)
    at /app/node_modules/express/lib/router/index.js:281:22
    at Function.process_params (/app/node_modules/express/lib/router/index.js:341:12)
mgol commented 2 months ago

A workaround for now is to avoid clicking "Download" on a theme but instead to click "Edit" and then "Download theme".

mgol commented 2 months ago

It turns out that the values for the Base & Vader themes were incorrect. I updated all the values in this PR so that they're compressed with the latest LZMA version.

PR: #609