search

jquery / download.jqueryui.com

Download Builder for jQuery UI
https://jqueryui.com/download/
Other
86 stars 72 forks source link

Download Builder: generates files with confusing dates in headers (.css/.js) #605

Open Chealer opened 11 months ago

Chealer commented 11 months ago

jQuery UI's (proper) CSS and JavaScript files start with headers, such as the following (from jquery-ui.js in jQuery UI 1.13.2's Development Bundle):

/*! jQuery UI - v1.13.2 - 2022-07-14
* http://jqueryui.com
* Includes: widget.js, [...]
* Copyright jQuery Foundation and other contributors; Licensed MIT */

The date is the release date of this jQuery UI version.

The Download Builder tool is very useful to generate a package of jQuery UI tailored to the user's needs. However, the date in these headers is different for the files it generates. I downloaded a custom build of jQuery UI 1.13.2 today (2023-11-07), and its headers contain:

jQuery UI - v1.13.2 - 2023-11-05

This date corresponds neither to the moment when I downloaded (2023-11-07), nor to jQuery UI 1.13.2's release date. This date is more confusing than helpful.

It should be either removed, fixed or described.

mgol commented 10 months ago

Thanks for the report. I transferred it to the Download Builder repository.

The date added is the date when the build was generated. This may be in the past when the build you fetch is cached.

I'd be fine with changing that to the release date of a particular version of jQuery UI. It's probably not a very pressing issue. PRs welcome if they're not too complex.

I think this is the place where the date is generated: https://github.com/jquery/download.jqueryui.com/blob/0df89e0efd3e02012185de85e4d6c7787978c8b5/lib/banner.js#L26

The cache code is in https://github.com/jquery/download.jqueryui.com/blob/0df89e0efd3e02012185de85e4d6c7787978c8b5/lib/cache.js.