jquery / infrastructure-puppet

Puppet configuration for jQuery Infrastructure servers.
MIT License
6 stars 9 forks source link

Remove `npm update` step from builder notifier scripts #38

Open Krinkle opened 8 months ago

Krinkle commented 8 months ago

There's a trade-off here between automatic updates and consistency/reproducibility with lock files. I think for the long-term, the latter is more favourable given we're not super fast moving. Also, these aren't long-running or public services, so there isn't an inherent benefit to automatic updates from that angle, either.

Source: https://github.com/jquery/infrastructure-puppet/blob/36c836b89b9c4f2458005afd00b03762aa9cc3d1/modules/profile/files/builder/builder-do-update.sh#L15