search

jquery / infrastructure-puppet

Puppet configuration for jQuery Infrastructure servers.
MIT License
6 stars 9 forks source link

Changes to releaeses.jquery.com content are not deployed #40

Closed Krinkle closed 5 months ago

Krinkle commented 5 months ago

From @mgol:

it looks like https://releases.jquery.com is no longer getting properly updated. The first commit that didn't get deployed was yours https://github.com/jquery/codeorigin.jquery.com/commit/53da21880f4d29f46feccc5577fb36b988b180ab adding QUnit 2.20.0. The JS file is there: https://code.jquery.com/qunit/qunit-2.20.0.js so the CDN updates properly but the WordPress site is not.

Krinkle commented 5 months ago

I checked https://github.com/organizations/jquery/settings/hooks/425188059 just now, and on Feb 6, the commits for codeorigin repo did deliver their webhook to builder-02 without issue (received with HTTP 202).

Next thing to look at is sudo journalctl -u notifier -n 1000, to see whether anything interesting happens with relevant webhooks and the scripts they run. There is seemingly nothing there other than noise from random bots submitting non-JSON payloads.

krinkle@builder-02:/etc/notifier.d$ cat builder-releases_jquery_com.*

This contains:

if ( data.tag.match( /^v?\d+\.\d+\.\d+(-\d+)?$/ ) ) {

It looks like some change last year, accidentally applied the semver requirement to releases.jquery.com. Checking the repo, this indeed happened in Aug 2023 with commit https://github.com/jquery/infrastructure-puppet/commit/205212dd1ec1c2d9c779346dcdc905adbdfc6d68.

Note that https://stage.releases.jquery.com/ is fine and did show your changes already.

I've now removed the semver tag in https://github.com/jquery/infrastructure-puppet/commit/38756711eef75bf477fbc92cb6403f71cdbb7889. I then logged-into builder-02 and ran sudo run-puppet-agent (so that we don't have to wait upto 30min for the scheduled run).

I then re-delivered the webhook from the above link, and the change is now live at http://releases.jquery.com/.